fix: count reduces by 1 for each record deleted#7645
Merged
Conversation
Triggered by 40e959e on branch refs/heads/issue-7494
Contributor
Author
|
@grantfitzsimmons This pr accounts for the negative issue in addition to the duplicate delete issue. May I close pr-7635 to avoid duplicate fixes? |
emenslin
approved these changes
Jan 14, 2026
Collaborator
emenslin
left a comment
emenslin
left a comment
There was a problem hiding this comment.
- Create a query with at least 2 records
- Delete all the records that show up
- Verify that the results count decreases by 1 following each removal
- Verify that the results count is zero and non-negative once all records are deleted
Looks good!
01-14_11.34.mp4
Iwantexpresso
approved these changes
Jan 14, 2026
Contributor
Iwantexpresso
left a comment
Iwantexpresso
left a comment
There was a problem hiding this comment.
- Create a query with at least 2 records
- Delete all the records that show up
- Verify that the results count decreases by 1 following each removal
- Verify that the results count is zero and non-negative once all records are deleted
nice job!
combs-a
approved these changes
Feb 12, 2026
Collaborator
combs-a
left a comment
combs-a
left a comment
There was a problem hiding this comment.
- Create a query with at least 2 records
- Delete all the records that show up
- Verify that the results count decreases by 1 following each removal
- Verify that the results count is zero and non-negative once all records are deleted
Tested on sdnhmherps, looks good to me. Decrementing as expected. Good job! 👍
bhumikaguptaa
approved these changes
Feb 16, 2026
Collaborator
bhumikaguptaa
left a comment
bhumikaguptaa
left a comment
There was a problem hiding this comment.
- Create a query with at least 2 records
- Delete all the records that show up
- Verify that the results count decreases by 1 following each removal
- Verify that the results count is zero and non-negative once all records are deleted
Works as expected.
grantfitzsimmons
approved these changes
Feb 16, 2026
Member
grantfitzsimmons
left a comment
grantfitzsimmons
left a comment
There was a problem hiding this comment.
This is a UX review:
- Create a query with at least 2 records
- Delete all the records that show up
- Verify that the results count decreases by 1 following each removal
- Verify that the results count is zero and non-negative once all records are deleted
👍
CarolineDenis
approved these changes
Feb 18, 2026
github-project-automation
bot
moved this from 📋Back Log
to ✅Done
in General Tester Board
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7494
Fixes #4988
This fix continues a change from pr-7635 to fix a UI issue when a user deletes records through the query builder. Prior to the change, the results header in the returned query would delete records two at a time. This happened because
handleDeletewas being called twice, hence the need for thedeletingReftracking set.Checklist
self-explanatory (or properly documented)
Testing instructions